Skip to content

gh-143999: Fix: handle suspended state on types.coroutine wrappers #144000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 5 commits into from
Jan 20, 2026
Merged

gh-143999: Fix: handle suspended state on types.coroutine wrappers #144000

serhiy-storchaka merged 5 commits into from
Jan 20, 2026

Conversation

@hyongtao-code
Copy link
Contributor

@hyongtao-code hyongtao-code commented Jan 18, 2026 •
edited
Loading

Fix types.coroutine wrappers to expose the suspended state. Ensure inspect.getgeneratorstate() and getcoroutinestate() handle wrapped generators correctly.

@bedevere-app bedevere-app bot mentioned this pull request Jan 18, 2026
Closed
aisk
aisk reviewed Jan 18, 2026
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes Jan 20, 2026
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) January 20, 2026 09:48
@serhiy-storchaka serhiy-storchaka merged commit 76b484b into python:main Jan 20, 2026
47 checks passed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 20, 2026
@miss-islington-app
Copy link

miss-islington-app bot commented Jan 20, 2026

Thanks @hyongtao-code for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Jan 20, 2026

Thanks @hyongtao-code for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2026
@hyongtao-code @miss-islington
pythongh-143999: Fix: handle suspended state on types.coroutine wrapp…
4968cd6 
…ers (pythonGH-144000)

(cherry picked from commit 76b484b)

Co-authored-by: Yongtao Huang <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2026
@hyongtao-code @miss-islington
pythongh-143999: Fix: handle suspended state on types.coroutine wrapp…
a924d31 
…ers (pythonGH-144000)

(cherry picked from commit 76b484b)

Co-authored-by: Yongtao Huang <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 20, 2026

GH-144066 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jan 20, 2026
@bedevere-app
Copy link

bedevere-app bot commented Jan 20, 2026

GH-144065 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 20, 2026
@bedevere-bot
Copy link

bedevere-bot commented Jan 20, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit 76b484b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/13244) and take a look at the build logs.
  4. Check if the failure is related to this commit (76b484b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/13244

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 947, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 947, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=13 mode='wb' closefd=True>

serhiy-storchaka pushed a commit that referenced this pull request Jan 20, 2026
@miss-islington @hyongtao-code
[3.13] gh-143999: Fix: handle suspended state on types.coroutine wrap…
11bf6ef 
…pers (GH-144000) (GH-144065)

(cherry picked from commit 76b484b)

Co-authored-by: Yongtao Huang <[email protected]>
@hyongtao-code hyongtao-code deleted the fix-suspended branch January 20, 2026 10:59
serhiy-storchaka pushed a commit that referenced this pull request Jan 20, 2026
@miss-islington @hyongtao-code
[3.14] gh-143999: Fix: handle suspended state on types.coroutine wrap…
6293e1e 
…pers (GH-144000) (GH-144066)

(cherry picked from commit 76b484b)

Co-authored-by: Yongtao Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hyongtao-code @bedevere-bot @aisk @serhiy-storchaka